Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper changes #1768

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Helper changes #1768

merged 1 commit into from
Feb 28, 2019

Conversation

atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Feb 28, 2019 •
edited
Loading

Description
There are some return types and description spelling mistakes present, which need to be corrected for a better understanding

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry jim-parry merged commit 9d4ad84 into codeigniter4:develop Feb 28, 2019
@jim-parry
Copy link
Contributor

It took a bit, but you got it :)

@atishhamte
Copy link
Contributor Author

Thanks. Now I know the process, I will contribute more in terms of corrections or additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atishhamte @jim-parry